Fix failures to h2spec test and make h2spec test more resilient #6881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Partially addresses issue #6878 |
masaori335
reviewed
Jun 10, 2020
| // Send EOS to let SM know that we aren't sticking around | ||
| if (_sm && read_vio.cont) { | ||
| // Only bother with the EOS if we haven't sent the write complete | ||
| if (!sent_write_complete) { |
Contributor
There was a problem hiding this comment.
Does this mean this function sends VC_EVENT_EOS even if VC_EVENT_WRITE_COMPLETE was sent? Looks a bit weird.
Member
Author
There was a problem hiding this comment.
Agreed. I was trying to back things out of the Http2 part of #6732. Let me try again with only the h2spec timeout extension.
Contributor
|
[approve ci autest] autest was skipped :( |
Member
Author
|
Closing. Parts will reappear in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another solution to PR #6879
Adjusts a change in #6732 to ensure that the error frame is emitted.
Also adjusts the timeout for h2spec from the default of 2 seconds to 10. I was seeing failures in the concurrent stream overflow test (5.1.2) where sometimes it would succeed and sometimes timeout. This was with and without the changes in #6732.