Make QPACK.h self-contained #6906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Backporting this commit to 9.0.x is optional, but it would make commit history clear. The change will be backported anyway as a part of draft-27 support. |
masaori335
approved these changes
Jun 22, 2020
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
I was able to build this PR with the main change of #6905.
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6905 revealed QPACK.h is not self-contained. This change will fix the compile error on #6905.