Fix rare SSN/TXN Start/Close Hook misorderings (#6364) #6936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick 37cc7b8 for openclose_h2 AuTest. - without changes in test/gold_tests/ - without changes of removing `client_vc->do_io_close()` from `Http1ClientSession::do_io_close()` and `Http2ClientSession::do_io_close()`. Because it made a bunch of crashes. ---- - Fix rare SSN/TXN Start/Close Hook misorderings - Fix h2spec test failure Co-authored-by: a-a-ron acanary@verizonmedia.com (cherry picked from commit 37cc7b8) Conflicts: proxy/ProxyClientSession.cc proxy/ProxySession.h proxy/http/HttpSM.cc proxy/http/Http1ClientSession.cc proxy/http2/Http2Stream.cc proxy/http2/Http2ClientSession.cc tests/gold_tests/continuations/openclose.test.py tests/gold_tests/continuations/openclose_h2.test.py tests/gold_tests/pluginTest/test_hooks/log.gold tests/gold_tests/pluginTest/test_hooks/test_hooks.test.py tests/tools/plugins/ssntxnorder_verify.cc
Contributor
Author
|
Build failure on Fedora with TCL looks unrelated to this PR. The env is changed recently? |
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 9, 2020
…pache#6936)" This reverts commit 0912e18.
zwoop
pushed a commit
that referenced
this pull request
Jul 13, 2020
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Mar 31, 2021
* asf/8.1.x: Updated ChangeLog Fix rare SSN/TXN Start/Close Hook misorderings (apache#6364) (apache#6936) Fix old MIMEHdr handling of HPACK Revert "crr and slice cherry picks, broken crr unit test" crr and slice cherry picks, broken crr unit test
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
Mar 31, 2021
…pache#6936)" (apache#93) This reverts commit 0912e18.
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Mar 31, 2021
* asf/8.1.x: Updated ChangeLog Fix memory leak in header_rewrite (apache#6986) Revert "Fix rare SSN/TXN Start/Close Hook misorderings (apache#6364) (apache#6936)" (apache#6989) Fixes use of TS_USE_TLS_OCSP (apache#6987)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #6364 to 8.1.x to fix
openclose_h2AuTest failure.client_vc->do_io_close()fromHttp1ClientSession::do_io_close()andHttp2ClientSession::do_io_close().Because it made a bunch of crashes.
Fix rare SSN/TXN Start/Close Hook misorderings
Fix h2spec test failure
Co-authored-by: a-a-ron acanary@verizonmedia.com
(cherry picked from commit 37cc7b8)
Conflicts:
proxy/ProxyClientSession.cc
proxy/ProxySession.h
proxy/http/HttpSM.cc
proxy/http/Http1ClientSession.cc
proxy/http2/Http2Stream.cc
proxy/http2/Http2ClientSession.cc
tests/gold_tests/continuations/openclose.test.py
tests/gold_tests/continuations/openclose_h2.test.py
tests/gold_tests/pluginTest/test_hooks/log.gold
tests/gold_tests/pluginTest/test_hooks/test_hooks.test.py
tests/tools/plugins/ssntxnorder_verify.cc