Build test C/C++ files with Automake. (#6945) #7165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many AuTests have test plugins or test executables that are used as a part of the test. Before this change these were built by ad hoc calls to g++ or gcc via shell executions from within the test or one of a couple AuTest extensions. This patch removes the building of these files from AuTest and instead uses the Automake build system to build these. This will build these utilities in a way that is consistent with the rest of the system, using the same warning and error flags, the same clang tool configurations, etc. (cherry picked from commit 61f8ee3)
bneradt
force-pushed
the
test_automake_changes_90x_6945
branch
from
c513c91 to
caa0de5
Compare
Contributor
Author
|
[approve ci autest] |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jan 26, 2021
* asf/9.0.x: Fix apache#7167, make autopep8 failure (apache#7168) Adding autopep8 as a pre-commit hook. (apache#7071) Build test C/C++ files with Automake. (apache#6945) (apache#7165) MicroDNS Extension: handle different 'default' types (apache#7159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick with resolved merge conflicts for the following PR:
#6945
Many AuTests have test plugins or test executables that are used as a
part of the test. Before this change these were built by ad hoc calls to
g++ or gcc via shell executions from within the test or one of a couple
AuTest extensions. This patch removes the building of these files from
AuTest and instead uses the Automake build system to build these. This
will build these utilities in a way that is consistent with the rest of
the system, using the same warning and error flags, the same
clang tool configurations, etc.
(cherry picked from commit 61f8ee3)