Skip to content

KWF useless member function HttpSM::kill_this_async_hook(). #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ywkaras merged 1 commit into from
Sep 17, 2020
Merged

KWF useless member function HttpSM::kill_this_async_hook(). #7198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions proxy/http/HttpSM.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,16 +464,7 @@ HttpSM::state_remove_from_list(int event, void * /* data ATS_UNUSED */)
HttpSMList[bucket].sm_list.remove(this);
}

return this->kill_this_async_hook(EVENT_NONE, nullptr);
}

int
HttpSM::kill_this_async_hook(int /* event ATS_UNUSED */, void * /* data ATS_UNUSED */)
{
// In the base HttpSM, we don't have anything to
// do here. subclasses can override this function
// to do their own asynchronous cleanup
// So We're now ready to finish off the state machine
// We're now ready to finish off the state machine
terminate_sm = true;
kill_this_async_done = true;

Expand Down
1 change: 0 additions & 1 deletion proxy/http/HttpSM.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,6 @@ class HttpSM : public Continuation, public PluginUserArgs<TS_USER_ARGS_TXN>
bool terminate_sm = false;
bool kill_this_async_done = false;
bool parse_range_done = false;
virtual int kill_this_async_hook(int event, void *data);
void kill_this();
void update_stats();
void transform_cleanup(TSHttpHookID hook, HttpTransformInfo *info);
Expand Down
5 changes: 0 additions & 5 deletions proxy/http/remap/unit-tests/nexthop_test_stubs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ void
HttpSM::set_next_state()
{
}
int
HttpSM::kill_this_async_hook(int event, void *data)
{
return 0;
}

HttpVCTable::HttpVCTable(HttpSM *smp)
{
Expand Down
6 changes: 0 additions & 6 deletions src/traffic_quic/traffic_quic.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,6 @@ HttpSM::handle_api_return()
ink_abort("do not call stub");
}

int
HttpSM::kill_this_async_hook(int /* event ATS_UNUSED */, void * /* data ATS_UNUSED */)
{
return EVENT_DONE;
}

void
HttpSM::attach_client_session(ProxyTransaction *, IOBufferReader *)
{
Expand Down