Skip to content

Addresses some of the lock contention with HostStatus. #7377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrushford merged 1 commit into from
Dec 18, 2020
Merged

Addresses some of the lock contention with HostStatus. #7377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions proxy/ParentConsistentHash.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ ParentConsistentHash::selectParent(bool first_call, ParentResult *result, Reques
pRec = nullptr;
}
if (firstCall) {
HostStatRec *hst = (pRec) ? pStatus.getHostStatus(pRec->hostname) : nullptr;
result->first_choice_status = (hst) ? hst->status : HostStatus_t::HOST_STATUS_UP;
break;
}
} while (pRec && !firstCall && last_lookup == PRIMARY && strcmp(pRec->hostname, result->hostname) == 0);
Expand All @@ -217,6 +215,10 @@ ParentConsistentHash::selectParent(bool first_call, ParentResult *result, Reques
// didn't find a parent or the parent is marked unavailable or the parent is marked down
HostStatRec *hst = (pRec) ? pStatus.getHostStatus(pRec->hostname) : nullptr;
host_stat = (hst) ? hst->status : HostStatus_t::HOST_STATUS_UP;
if (firstCall) {
result->first_choice_status = host_stat;
}

// if the config ignore_self_detect is set to true and the host is down due to SELF_DETECT reason
// ignore the down status and mark it as avaialble
if ((pRec && result->rec->ignore_self_detect) && (hst && hst->status == HOST_STATUS_DOWN)) {
Expand Down Expand Up @@ -313,9 +315,6 @@ ParentConsistentHash::selectParent(bool first_call, ParentResult *result, Reques
// Validate and return the final result.
// ----------------------------------------------------------------------------------------------------

// use the available or marked for retry parent.
hst = (pRec) ? pStatus.getHostStatus(pRec->hostname) : nullptr;
host_stat = (hst) ? hst->status : HostStatus_t::HOST_STATUS_UP;
// if the config ignore_self_detect is set to true and the host is down due to SELF_DETECT reason
// ignore the down status and mark it as avaialble
if ((pRec && result->rec->ignore_self_detect) && (hst && hst->status == HOST_STATUS_DOWN)) {
Expand Down
9 changes: 9 additions & 0 deletions src/traffic_server/HostStatus.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,15 @@ HostStatus::getHostStatus(const char *name)
time_t now = time(0);
bool lookup = false;

// if host_statuses is empty, just return
// a nullptr as there is no need to lock
// and search. A return of nullptr indicates
// to the caller that the host is available,
// HOST_STATUS_UP.
if (hosts_statuses.empty()) {
return _status;
}

// the hash table value pointer has the HostStatus_t value.
ink_rwlock_rdlock(&host_status_rwlock);
{
Expand Down