Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM: Remove superfluous const qualifier in return type #7412

Merged
merged 1 commit into from
Jan 11, 2021
Merged

LGTM: Remove superfluous const qualifier in return type #7412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/tscore/AtomicBit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class AtomicBit
}

// allow cast to bool
explicit operator const bool() const { return (*_byte_ptr) & _mask; }
explicit operator bool() const { return (*_byte_ptr) & _mask; }

// allows compare with bool
bool
Expand Down
4 changes: 2 additions & 2 deletions include/tscore/Extendible.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ namespace details
/// Bool specializations

template <typename Derived_t>
const bool
bool
fieldGet(const void *fld_ptr, FieldId<Derived_t, bool> const &field)
{
return bool((*static_cast<const uint8_t *>(fld_ptr)) & field.desc->mask);
Expand Down Expand Up @@ -395,7 +395,7 @@ namespace details
/// std::atomic<bool> specializations (same as bool)

template <typename Derived_t>
inline const bool
inline bool
fieldGet(void const *fld_ptr, FieldId<Derived_t, std::atomic<bool>> const &field)
{
return bool(fld_ptr & field.mask);
Expand Down
2 changes: 1 addition & 1 deletion iocore/net/quic/QUICTypes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ QUICResumptionToken::cid() const
return QUICTypeUtil::read_QUICConnectionId(this->_token + (1 + 20 + 4), this->_token_len - (1 + 20 + 4));
}

const ink_hrtime
ink_hrtime
QUICResumptionToken::expire_time() const
{
return QUICIntUtil::read_nbytes_as_uint(this->_token + (1 + 20), 4);
Expand Down
2 changes: 1 addition & 1 deletion iocore/net/quic/QUICTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ class QUICResumptionToken : public QUICAddressValidationToken
bool is_valid(const IpEndpoint &src) const;

const QUICConnectionId cid() const;
const ink_hrtime expire_time() const;
ink_hrtime expire_time() const;
};

class QUICRetryToken : public QUICAddressValidationToken
Expand Down
2 changes: 1 addition & 1 deletion plugins/experimental/ssl_session_reuse/src/connection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class connection
* management.
* @return
*/
inline redisContext *const
inline redisContext *
c_ptr() const
{
return c;
Expand Down