Skip to content

Conversation

@maskit
Copy link
Member

@maskit maskit commented Jan 26, 2021

@maskit maskit added the Plugins label Jan 26, 2021
@maskit maskit added this to the 10.0.0 milestone Jan 26, 2021
@maskit maskit self-assigned this Jan 26, 2021
@maskit maskit changed the title Openssl3 s3 auth Use EVP API instead of legacy APIs (s3 auth) Jan 26, 2021
@maskit
Copy link
Member Author

maskit commented Jan 26, 2021

[approve ci Clang-Analyzer]

@maskit
Copy link
Member Author

maskit commented Jan 26, 2021

Autest failure is because of OpenSSL on the box. It uses an old snapshot of OpenSSL master (+ QUIC patch) that has some new functions but not ones recently added. Although I could check availability of functions more strictly, that would not make much sense at the moment (until some incompatible changes happen in the future) because the new functions used on this PR are in the same series of OpenSSL API (EVP MAC). If one of them is available the others should be available at least on the next major release.

shinrich
shinrich previously approved these changes Mar 5, 2021
@maskit
Copy link
Member Author

maskit commented Mar 9, 2021

This is on hold because there's a discussion about heap allocation on #7447. We may prefer to use the old API as long as it's available.

@maskit maskit added the WIP label Mar 9, 2021
@bryancall bryancall requested a review from shinrich May 17, 2021 23:07
@shinrich shinrich dismissed their stale review May 17, 2021 23:07

Moved to WIP

@maskit maskit marked this pull request as draft May 17, 2021 23:25
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

@github-actions github-actions bot added the Stale label Aug 16, 2021
@github-actions github-actions bot closed this Aug 24, 2021
@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants