Skip to content

Fixing DNS local_ipv* config option #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezelkow1 merged 1 commit into from
Feb 9, 2021
Merged

Fixing DNS local_ipv* config option #7507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions doc/admin-guide/files/records.config.en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2570,6 +2570,15 @@ DNS

Maximum number of retries made by |TS| on a given DNS query

.. ts:cv:: CONFIG proxy.config.dns.local_ipv4 STRING NULL

Local IPV4 address to bind to in order to make DNS requests

.. ts:cv:: CONFIG proxy.config.dns.local_ipv6 STRING NULL

Local IPV6 address to bind to in order to make DNS requests


HostDB
======

Expand Down
11 changes: 0 additions & 11 deletions iocore/dns/DNSConnection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,17 +140,6 @@ DNSConnection::connect(sockaddr const *addr, Options const &opt)

if (opt._bind_random_port) {
int retries = 0;
IpEndpoint bind_addr;
size_t bind_size = 0;
memset(&bind_addr, 0, sizeof bind_addr);
bind_addr.sa.sa_family = af;
if (AF_INET6 == af) {
bind_addr.sin6.sin6_addr = in6addr_any;
bind_size = sizeof bind_addr.sin6;
} else {
bind_addr.sin.sin_addr.s_addr = INADDR_ANY;
bind_size = sizeof bind_addr.sin;
}
while (retries++ < 10000) {
ip_port_text_buffer b;
uint32_t p = generator.random();
Expand Down