TS-4542: ASAN error with HTTP/2 #760
Conversation
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/372/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/268/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/374/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/270/ for details. |
proxy/http2/Http2ConnectionState.cc
Outdated
| } | ||
|
|
||
| if (stream->is_body_done() && payload_length < available_size) { | ||
| if (stream->is_body_done() && payload_length <= available_size) { |
There was a problem hiding this comment.
This could be problem when response body size is larger than 16375.
$ /opt/nghttp2/bin/nghttp -n "https://127.0.0.1:4443/httpbin/bytes/16376"
Some requests were not processed. total=1, processed=0
There was a problem hiding this comment.
IMO, to stop sending 0 payload DATA frame with END_STREAM flag, we need to check read available size of current_reader. Something like this.
https://paste.apache.org/8eVP
There was a problem hiding this comment.
Yeah, I updated the patch with <= so that it would set the END_STREAM on a 0 length frame. Thanks for the feedback about > 16375.
|
Looks good to me. |
|
Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/276/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/380/ for details. |
|
LGTM |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/381/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/277/ for details. |
) (apache#760) * Updated log message * Added a comment (cherry picked from commit ec3bcf3)
4 participants
No description provided.