Skip to content

Comment why log eviction isn't implemented via a log field. #7648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
Mar 30, 2021
Merged

Comment why log eviction isn't implemented via a log field. #7648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions iocore/cache/CacheWrite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ CacheVC::updateVector(int /* event ATS_UNUSED */, Event * /* e ATS_UNUSED */)
od->move_resident_alt = false;
}
if (cache_config_log_alternate_eviction) {
// Initially there was an attempt to make alternate eviction a log
// field. However it was discovered this could not work because this
// code, in which alternates are evicted, happens during the processing
// of IO which happens after transaction logs are emitted and after the
// HttpSM is destructed. Instead, therefore, alternate eviction logging
// was implemented for diags.log with the
// proxy.config.cache.log.alternate.eviction toggle.
CacheHTTPInfo *info = write_vector->get(0);
HTTPHdr *request = info->request_get();
if (request->valid()) {
Expand Down