Add NixOS support #7697
Merged
Add NixOS support #7697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midchildan
commented
Apr 11, 2021
Comment on lines
+281
to
+299
| <Layout NixOS> | ||
| prefix: /opt/trafficserver | ||
| exec_prefix: ${prefix} | ||
| bindir: ${exec_prefix}/bin | ||
| sbindir: ${exec_prefix}/sbin | ||
| libdir: ${exec_prefix}/lib | ||
| libexecdir: ${exec_prefix}/libexec | ||
| infodir: ${prefix}/share/info | ||
| mandir: ${prefix}/share/man | ||
| sysconfdir: /etc+ | ||
| datadir: ${prefix}/share+ | ||
| docdir: ${prefix}/share/doc+ | ||
| installbuilddir: ${datadir}/build | ||
| includedir: ${prefix}/include | ||
| localstatedir: /var/lib+ | ||
| runtimedir: /run+ | ||
| logdir: /var/log+ | ||
| cachedir: /var/cache+ | ||
| </Layout> |
Contributor
Author
There was a problem hiding this comment.
About half of these are replaced through configure flags when building with Nix, but I still added them for the sake of consistency.
Comment on lines
+207
to
+209
| if [[ "$INSTALLDIR" = /nix/store* ]]; then | ||
| bail "unsupported option: -i is disabled on Nix" | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
/nix/store is where packages are installed and is non-writable.
| [Unit] | ||
| Description=Apache Traffic Server is a fast, scalable and extensible caching proxy server. | ||
| After=syslog.target network.target | ||
| After=network.target |
Contributor
Author
There was a problem hiding this comment.
syslog.target is removed from recent versions of systemd.
| export TM_PIDFILE=$(@exp_bindir@/traffic_layout 2>/dev/null | grep RUNTIMEDIR | cut -d: -f2)/manager.lock ; \ | ||
| /bin/rm $TM_PIDFILE ; \ | ||
| if [[ $? -ne 0 ]]; then echo "ERROR: Unable to delete PID"; exit 1; fi' | ||
| PIDFile=@exp_runtimedir@/manager.lock |
Contributor
Author
There was a problem hiding this comment.
Using PIDFile to clean up PID files is slightly more portable, as some distros don't have /bin/rm.
10 tasks
bryancall
added
Build
bryancall
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of an attempt to package Traffic Server in Nixpkgs.