Skip to content

if transaction status non-success, bypass intercept plugin #7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randall merged 2 commits into from
Apr 23, 2021
Merged

if transaction status non-success, bypass intercept plugin #7724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2af1c1e
if transaction status non-success, bypass intercept plugin
randall Apr 20, 2021
037bc76
slice: Cleanup status code checking
randall Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/experimental/slice/slice.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ read_request(TSHttpTxn txnp, Config *const config)
if (!header.hasKey(SLICER_MIME_FIELD_INFO, SLICER_MIME_LEN_INFO)) {
// check if any previous plugin has monkeyed with the transaction status
TSHttpStatus const txnstat = TSHttpTxnStatusGet(txnp);
if (0 != static_cast<int>(txnstat)) {
DEBUG_LOG("txn status change detected (%d), skipping plugin\n", (int)txnstat);
if (TS_HTTP_STATUS_NONE != txnstat) {
DEBUG_LOG("txn status change detected (%d), skipping plugin\n", static_cast<int>(txnstat));
return false;
}

Expand Down
6 changes: 6 additions & 0 deletions plugins/experimental/statichit/statichit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,12 @@ TSRemapInit(TSRemapInterface * /* api_info */, char * /* errbuf */, int /* errbu
TSRemapStatus
TSRemapDoRemap(void *ih, TSHttpTxn rh, TSRemapRequestInfo *rri)
{
const TSHttpStatus txnstat = TSHttpTxnStatusGet(rh);
if (txnstat != TS_HTTP_STATUS_NONE && txnstat != TS_HTTP_STATUS_OK) {
VDEBUG("transaction status_code=%d already set; skipping processing", static_cast<int>(txnstat));
return TSREMAP_NO_REMAP;
}

StaticHitConfig *cfg = static_cast<StaticHitConfig *>(ih);

if (!cfg) {
Expand Down
6 changes: 6 additions & 0 deletions plugins/generator/generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,12 @@ TSRemapInit(TSRemapInterface * /* api_info */, char * /* errbuf */, int /* errbu
TSRemapStatus
TSRemapDoRemap(void * /* ih */, TSHttpTxn txn, TSRemapRequestInfo *rri)
{
const TSHttpStatus txnstat = TSHttpTxnStatusGet(txn);
if (txnstat != TS_HTTP_STATUS_NONE && txnstat != TS_HTTP_STATUS_OK) {
VDEBUG("transaction status_code=%d already set; skipping processing", static_cast<int>(txnstat));
return TSREMAP_NO_REMAP;
}

// Check if we should turn off the cache before doing anything else ...
CheckCacheable(txn, rri->requestUrl, rri->requestBufp);
TSHttpTxnHookAdd(txn, TS_HTTP_CACHE_LOOKUP_COMPLETE_HOOK, TxnHook);
Expand Down