-
Notifications
You must be signed in to change notification settings - Fork 844
TS-4507: Fix SSN and TXN hook ordering. #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/407/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/301/ for details. |
|
These fixes improved the stability of our 5.3.x + TS-3612 build. I'm heading out until July 14, but I wanted to make these changes available in case anyone else was seeing stability problems in this area. |
|
Is is possible to break the addditional fixes out into separate tickets and PRs? |
|
It would be possible to break out the schedule_event clean up and the state_api_callout into smaller patches. The rest of it really needs to be together. I need to move onto another project by Monday. I'll see what I can get done this afternoon. Otherwise these fixes will need to wait a while. |
|
Pushed new version of the branch that does not include the schedule_event and state_api_callout fixes. Filed TS-4663 and TS-4664 to track those issues. Will try to reproduce those fixes on new branches. |
|
FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/432/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/325/ for details. |
|
I've reviewed the changes and I don't think they can really be split up. Part of the reason is similar changes in both the HTTP/1 and HTTP/2 classes, which makes the change appear bigger than it is. I'm +1 on committing this, especially since we've been successfully testing them in production inside Yahoo!. |
This cherry-picks two PRs from Vinith to 10.0.x from 9.1.x: * apache#779 * apache#784
This change was motivated by dealing with ordering problems between SSN_CLOSE and TXN_CLOSE causing problems (crashes). This we addressed as follows
In addition this PR includes the following fixes.