Pin Sphinx to 3.x to unblock make html
#7987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of Sphinx, 4.0.2, fails to build our docs via the make html target. The latest 3.x release, currently 3.5.4, builds our docs fine. Pinning to 3.x. This also makes a fix for an API change in which sphinx.locale no longer has `l_`.
randall
approved these changes
Jun 26, 2021
Contributor
Author
|
I noticed this got marked for the 9.1.x project, but this is not needed there (and probably would result in a merge conflict if tried). The following PR for 9.1.x/master has already been merged in for this change: #7940 I know this is a bit confusing, but this present PR (#7987) is a superset of that 9.1.x/master one (#7940), because the In any case, this PR should not go to 9.1.x nor master. This is just for 9.0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of Sphinx, 4.0.2, fails to build our docs via the
make html target. The latest 3.x release, currently 3.5.4, builds our
docs fine. Pinning to 3.x.
This also makes a fix for an API change in which sphinx.locale no longer
has
l_.