Skip to content

Suppress use-after-free report on UnixNetVConnection::startEvent by clang-analyzer #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masaori335 wants to merge 1 commit into from
Closed

Suppress use-after-free report on UnixNetVConnection::startEvent by clang-analyzer #8197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions iocore/net/UnixNetVConnection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,8 @@ UnixNetVConnection::netActivity(EThread *lthread)
net_activity(this, lthread);
}

// Avoid false positive of clang-analyzer (llvm-11 and 12). Details in #8198
#ifndef __clang_analyzer__
int
UnixNetVConnection::startEvent(int /* event ATS_UNUSED */, Event *e)
{
Expand All @@ -1008,6 +1010,13 @@ UnixNetVConnection::startEvent(int /* event ATS_UNUSED */, Event *e)
}
return EVENT_DONE;
}
#else
int
UnixNetVConnection::startEvent(int /* event ATS_UNUSED */, Event * /* e */)
{
return EVENT_DONE;
}
#endif

int
UnixNetVConnection::acceptEvent(int event, Event *e)
Expand Down