Add setting to allow different windows for stream and session #8203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
[approve ci clang-analyzer] |
Contributor
|
@masaori335 or @maskit can you please take a look at this PR |
maskit
reviewed
Sep 27, 2021
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
As I commented on the issue, I don't think this is a good solution. -0 from me.
Contributor
|
[approve ci] |
1 similar comment
Contributor
|
[approve ci] |
|
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
Closed
Contributor
|
Let's re-open this and pull it in separately from the new HTTP/2 to origin PR (#8963). |
Contributor
|
Since this has conflicts, I opened #9085 to take over from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #8199 outlines the issue. This PR adds a new setting to allow for setting the session window separately from the stream window.
This closes #8199