Skip to content

Fix mutex use after free #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traeak merged 3 commits into from
Aug 4, 2021
Merged

Fix mutex use after free #8209

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f73bad2
Fix mutex use after free
shinrich Aug 4, 2021
56f7d4d
One more try
shinrich Aug 4, 2021
f864900
Try again
shinrich Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions iocore/net/UnixNetVConnection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@ UnixNetVConnection::startEvent(int /* event ATS_UNUSED */, Event *e)
if (!action_.cancelled) {
connectUp(e->ethread, NO_FD);
} else {
this->free(e->ethread);
get_NetHandler(e->ethread)->free_netevent(this);
}
return EVENT_DONE;
}
Expand Down Expand Up @@ -1213,7 +1213,6 @@ UnixNetVConnection::connectUp(EThread *t, int fd)
res = con.connect(nullptr, options);
if (res != 0) {
// fast stopIO
nh = nullptr;
goto fail;
}
}
Expand All @@ -1239,7 +1238,7 @@ UnixNetVConnection::connectUp(EThread *t, int fd)
if (fd != NO_FD) {
con.fd = NO_FD;
}
free(t);
nh->free_netevent(this);
return CONNECT_FAILURE;
}

Expand Down