-
Notifications
You must be signed in to change notification settings - Fork 848
stats_over_http c++/ipmap updates #8335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@SolidWallOfCode is going to review this |
|
Just some notes for myself. After some discussions we want to:
This would let you do We still want to leave the global usage as is, allowing a config or if the file doesnt exist use the param as the path, or default to _stats just because global usage needs its own path. On a remap though it will be config file based or nothing at all |
|
Strike that, reverse it :) So we are just taking out the remap usage all together. Much of how this plugin works is legacy implementations, so if we want a remap plugin that can serve stats it should be done as just a whole new plugin written properly and so that it can be chained with other plugins. For now removing the new remap functionality. I will leave the existing rewrite though as we still need the proper IP parsing/map but for remap it should be a new plugin designed around using the ServerIntercept |
|
[approve ci rocky] |
|
See #8797 for stats_over_http reimplemented as a ServerIntercept. |
move ip allow setup to use ipmap if a config is used link it to remap to initiate plugin reload on config change
|
We have been running with this in production for a good while now |
move ip allow setup to use ipmap if a config is used link it to remap to initiate plugin reload on config change (cherry picked from commit 66412f0)
move ip allow setup to use ipmap if a config is used link it to remap to initiate plugin reload on config change
move ip allow setup to use ipmap if a config is used link it to remap to initiate plugin reload on config change (cherry picked from commit 66412f0) Add `current_time_epoch_ms` stat to be appended before the server version. This allows computation of stats externally based on the cache time frame. This can help alleviate issues with sliding windows between various stats programs that generate discrepencies (apache#9567) (cherry picked from commit 3c4c5fc) (cherry picked from commit 09c18979cc2725301c5a6649f0f4a4dff2851816)
convert to c++ plugin
move ip allow setup to use ipmap
if a config is used link it to remap to initiate plugin reload on config change