Skip to content

Conversation

@ezelkow1
Copy link
Member

@ezelkow1 ezelkow1 commented Sep 20, 2021

convert to c++ plugin
move ip allow setup to use ipmap
if a config is used link it to remap to initiate plugin reload on config change

@ezelkow1 ezelkow1 self-assigned this Sep 20, 2021
@ezelkow1 ezelkow1 requested a review from bryancall as a code owner September 20, 2021 19:49
@ezelkow1 ezelkow1 requested a review from zwoop September 20, 2021 21:23
@bryancall
Copy link
Contributor

@SolidWallOfCode is going to review this

@randall randall changed the title Stats_over_http c++/remap/ipmap updates stats_over_http c++/remap/ipmap updates Sep 21, 2021
@ezelkow1
Copy link
Member Author

ezelkow1 commented Dec 2, 2021

Just some notes for myself. After some discussions we want to:

  • Remove the default of _stats when being used as a remap plugin, so that the remap itself becomes the endpoint
  • Still allow setting of the path via config file when running as a remap

This would let you do
map http://mystats.com http://whatever.com @plugin=stats_over_http.so
and just be able to hit stats without the _stats endpoint on a remap. It would still be optionally available via the config file though for things like ATC which would require this.

We still want to leave the global usage as is, allowing a config or if the file doesnt exist use the param as the path, or default to _stats just because global usage needs its own path. On a remap though it will be config file based or nothing at all

@ezelkow1
Copy link
Member Author

ezelkow1 commented Dec 2, 2021

Strike that, reverse it :)

So we are just taking out the remap usage all together. Much of how this plugin works is legacy implementations, so if we want a remap plugin that can serve stats it should be done as just a whole new plugin written properly and so that it can be chained with other plugins.

For now removing the new remap functionality. I will leave the existing rewrite though as we still need the proper IP parsing/map but for remap it should be a new plugin designed around using the ServerIntercept

@ezelkow1 ezelkow1 changed the title stats_over_http c++/remap/ipmap updates stats_over_http c++/ipmap updates Dec 2, 2021
@ezelkow1
Copy link
Member Author

[approve ci rocky]

@randall
Copy link
Contributor

randall commented Apr 18, 2022

See #8797 for stats_over_http reimplemented as a ServerIntercept.

@zwoop zwoop added this to the 10.0.0 milestone May 26, 2022
move ip allow setup to use ipmap
if a config is used link it to remap to initiate plugin reload on config change
@ezelkow1
Copy link
Member Author

We have been running with this in production for a good while now

@ezelkow1 ezelkow1 merged commit 66412f0 into apache:master Aug 15, 2022
ezelkow1 added a commit to ezelkow1/trafficserver that referenced this pull request Aug 17, 2022
move ip allow setup to use ipmap
if a config is used link it to remap to initiate plugin reload on config change

(cherry picked from commit 66412f0)
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Aug 23, 2022
move ip allow setup to use ipmap
if a config is used link it to remap to initiate plugin reload on config change
traeak pushed a commit to traeak/trafficserver that referenced this pull request Aug 29, 2023
move ip allow setup to use ipmap
if a config is used link it to remap to initiate plugin reload on config change

(cherry picked from commit 66412f0)

Add `current_time_epoch_ms` stat to be appended before the server version. This allows computation of stats externally based on the cache time frame. This can help alleviate issues with sliding windows between various stats programs that generate discrepencies (apache#9567)

(cherry picked from commit 3c4c5fc)
(cherry picked from commit 09c18979cc2725301c5a6649f0f4a4dff2851816)
@zwoop zwoop added the WhatsNew label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants