Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metrics to the rate limit plugin and document the new options #8395

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

elsloo
Copy link
Contributor

@elsloo elsloo commented Oct 8, 2021

No description provided.

@elsloo elsloo requested a review from bryancall as a code owner October 8, 2021 17:45
@ezelkow1
Copy link
Member

ezelkow1 commented Oct 8, 2021

[approve ci]

@bryancall bryancall added this to the 10.0.0 milestone Oct 8, 2021
@bryancall bryancall requested a review from traeak October 11, 2021 23:10
@randall randall changed the title Added metrics to the rate limit plugin and documented the new options. Added metrics to the rate limit plugin and document the new options. Oct 18, 2021
@randall randall changed the title Added metrics to the rate limit plugin and document the new options. Added metrics to the rate limit plugin and document the new options Oct 18, 2021
plugins/experimental/rate_limit/utilities.cc Outdated Show resolved Hide resolved
plugins/experimental/rate_limit/limiter.h Outdated Show resolved Hide resolved
plugins/experimental/rate_limit/limiter.h Outdated Show resolved Hide resolved
* Fixed calculation for metric length that was counting too many things due to a prior implementation and lack of cleanup of this specific line of code
@elsloo
Copy link
Contributor Author

elsloo commented Oct 25, 2021

[approve ci fedora]

@ezelkow1
Copy link
Member

[approve ci autest]

1 similar comment
@elsloo
Copy link
Contributor Author

elsloo commented Oct 26, 2021

[approve ci autest]

Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin works as tested.

@traeak traeak merged commit a3f04cb into apache:master Oct 26, 2021
@zwoop
Copy link
Contributor

zwoop commented Apr 5, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Apr 5, 2022
zwoop pushed a commit that referenced this pull request Apr 5, 2022
…8395)

* Added metrics to the rate limit plugin and documented the new options.

* * Addressed feedback in PR review

* Fixed calculation for metric length that was counting too many things due to a prior implementation and lack of cleanup of this specific line of code

(cherry picked from commit a3f04cb)
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request May 26, 2022
* asf/9.2.x:
  Updated ChangeLog
  Adds an IP reputation system to the SNI rate limiter (apache#8459)
  Added metrics to the rate limit plugin and document the new options (apache#8395)
  STEK share plugin using Raft (apache#8751)
  Pin Jinja2 for doc builds (apache#8773)
  Lua plugin memory leak on remap configuration reloads (apache#8764)
  Add metrics for loop detection. (apache#8772)
  check return values of openssl api calls (apache#8758)
  Adding prefetch feature to slice plugin (apache#8723)
  Updated ChangeLog
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 19, 2023
…pache#8395)

* Added metrics to the rate limit plugin and documented the new options.

* * Addressed feedback in PR review

* Fixed calculation for metric length that was counting too many things due to a prior implementation and lack of cleanup of this specific line of code

(cherry picked from commit a3f04cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants