-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metrics to the rate limit plugin and document the new options #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[approve ci] |
traeak
reviewed
Oct 25, 2021
* Fixed calculation for metric length that was counting too many things due to a prior implementation and lack of cleanup of this specific line of code
[approve ci fedora] |
[approve ci autest] |
1 similar comment
[approve ci autest] |
traeak
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin works as tested.
Cherry-picked to v9.2.x |
zwoop
pushed a commit
that referenced
this pull request
Apr 5, 2022
…8395) * Added metrics to the rate limit plugin and documented the new options. * * Addressed feedback in PR review * Fixed calculation for metric length that was counting too many things due to a prior implementation and lack of cleanup of this specific line of code (cherry picked from commit a3f04cb)
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
May 26, 2022
* asf/9.2.x: Updated ChangeLog Adds an IP reputation system to the SNI rate limiter (apache#8459) Added metrics to the rate limit plugin and document the new options (apache#8395) STEK share plugin using Raft (apache#8751) Pin Jinja2 for doc builds (apache#8773) Lua plugin memory leak on remap configuration reloads (apache#8764) Add metrics for loop detection. (apache#8772) check return values of openssl api calls (apache#8758) Adding prefetch feature to slice plugin (apache#8723) Updated ChangeLog
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
…pache#8395) * Added metrics to the rate limit plugin and documented the new options. * * Addressed feedback in PR review * Fixed calculation for metric length that was counting too many things due to a prior implementation and lack of cleanup of this specific line of code (cherry picked from commit a3f04cb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.