Skip to content

url_sig: fix bad cast to pointer of different type #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traeak merged 1 commit into from
Nov 9, 2021
Merged

url_sig: fix bad cast to pointer of different type #8505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/experimental/url_sig/url_sig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,8 @@ urlParse(char const *const url_in, char *anchor, char *new_path_seg, int new_pat
unsigned char decoded_string[2048] = {'\0'};
char new_url[8192]; /* new_url is not null_terminated */
char *p = NULL, *sig_anchor = NULL, *saveptr = NULL;
int i = 0, numtoks = 0, decoded_len = 0, sig_anchor_seg = 0;
int i = 0, numtoks = 0, sig_anchor_seg = 0;
size_t decoded_len = 0;

strncat(url, url_in, sizeof(url) - strlen(url) - 1);

Expand Down Expand Up @@ -477,13 +478,12 @@ urlParse(char const *const url_in, char *anchor, char *new_path_seg, int new_pat
// no signature anchor was found so decode and save the signing parameters assumed
// to be in the last path segment.
if (sig_anchor == NULL) {
if (TSBase64Decode(segment[numtoks - 2], strlen(segment[numtoks - 2]), decoded_string, sizeof(decoded_string),
(size_t *)&decoded_len) != TS_SUCCESS) {
if (TSBase64Decode(segment[numtoks - 2], strlen(segment[numtoks - 2]), decoded_string, sizeof(decoded_string), &decoded_len) !=
TS_SUCCESS) {
TSDebug(PLUGIN_NAME, "Unable to decode the path parameter string.");
}
} else {
if (TSBase64Decode(sig_anchor, strlen(sig_anchor), decoded_string, sizeof(decoded_string), (size_t *)&decoded_len) !=
TS_SUCCESS) {
if (TSBase64Decode(sig_anchor, strlen(sig_anchor), decoded_string, sizeof(decoded_string), &decoded_len) != TS_SUCCESS) {
TSDebug(PLUGIN_NAME, "Unable to decode the path parameter string.");
}
}
Expand Down