Don't use Http1ClientTransaction as an event handler #8609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancall
approved these changes
Jan 18, 2022
zwoop
pushed a commit
that referenced
this pull request
Jan 18, 2022
(cherry picked from commit b9f0019)
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog TSHttpTxnCacheLookupStatusGet: handle cannot respond cases (apache#8545) Update to Proxy Verifier version v2.3.0 (apache#8608) Don't use Http1ClientTransaction as an event handler (apache#8609) Eliminate erroneous self-loop error on transparent mode (apache#8586) Clean up of next hop HostRecord class. (apache#8585) Propagate accept options to HTTP/2 (apache#8594) add --with-mimalloc option (apache#8233) Fix transparent mode documentation (apache#8593) Docs: Slack instead of irc (apache#8599) LogFilter: fix NULL termination check (apache#8603) Fixes a scoping bug that leads to "sticky" weights (apache#8606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Http1ClientTransactionas an event hander (in other words, passing it todo_io_readas a continuation) does not make sense because it does not have code for event handling.The point of this
do_io_readseems to be passing 0 and nullptr as the 2nd and 3rd argument, but not changing the continuation, and the original continuation here is probably always HttpSM.This closes #8604.