Skip to content

Clear random header value by AIO read error (#8559) #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezelkow1 merged 1 commit into from
Feb 7, 2022
Merged

Clear random header value by AIO read error (#8559) #8653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion iocore/cache/CacheDisk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ CacheDisk::open(char *s, off_t blocks, off_t askip, int ahw_sector_size, int fil
}
}

//
// read disk header
SET_HANDLER(&CacheDisk::openStart);
io.aiocb.aio_offset = skip;
io.aiocb.aio_buf = (char *)header;
Expand Down Expand Up @@ -166,6 +166,10 @@ CacheDisk::openStart(int event, void * /* data ATS_UNUSED */)

if ((size_t)io.aiocb.aio_nbytes != (size_t)io.aio_result) {
Warning("could not read disk header for disk %s: declaring disk bad", path);

// the header could have random values by the AIO read error
memset(header, 0, header_len);

incrErrors(&io);
SET_DISK_BAD(this);
SET_HANDLER(&CacheDisk::openDone);
Expand Down