Require use of 'override' keyword when valid. (#8737) #8740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Walt Karas <wkaras@yahooinc.com> (cherry picked from commit 97ee33c)
ywkaras
requested review from
SolidWallOfCode,
bryancall,
masaori335 and
maskit
as code owners
brbzull0
approved these changes
Mar 18, 2022
SolidWallOfCode
approved these changes
Mar 21, 2022
Contributor
|
Kind of backporting #8737 to the 10-dev branch? |
jrushford
added a commit
to jrushford/trafficserver
that referenced
this pull request
Mar 22, 2022
now required from PR apache#8737 apache#8740
jrushford
added a commit
that referenced
this pull request
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.