HttpSM, HttpTunnel, and Http2Stream debug logging updates #8788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling debug logging with the http tag, it is often helpful to be able to identify logs based on the corresponding state machine ID. This is especially the case when there is a significant amount of concurrent traffic such that many logs from different state machines are being emitted at the same time. This patch updates logging calls to more consistently add the associated state machine ID for such logs.
|
@masaori335 is going to take a look at this |
masaori335
reviewed
Apr 14, 2022
Debug messages already contain the function names, so it's redundant to specify them in the debug log line. Removing places where this redundancy existed.
zwoop
pushed a commit
that referenced
this pull request
Apr 20, 2022
When enabling debug logging with the http tag, it is often helpful to be able to identify logs based on the corresponding state machine ID. This is especially the case when there is a significant amount of concurrent traffic such that many logs from different state machines are being emitted at the same time. This patch updates logging calls to more consistently add the associated state machine ID for such logs. Also: debug messages already contain the function names, so it's redundant to specify them in the debug log line. Removing places where this redundancy existed. (cherry picked from commit 360aafb)
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
May 26, 2022
* asf/9.2.x: Updated ChangeLog HttpSM, HttpTunnel, and Http2Stream debug logging updates (apache#8788) Fix plugin parent_select failover (apache#8676) Adds new plugin, http_stats (apache#8797) SIGTERM should cause traffic_manager to exit with status 0 as a shutdown method (apache#8798) Avoid allocation when matching hosts for vol lookup (apache#8762) Check bounds before accessing Vol::evacuate array (apache#8716) Adds a simple tool to generate new escape tables (apache#8783)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling debug logging with the http tag, it is often helpful to be
able to identify logs based on the corresponding state machine ID. This
is especially the case when there is a significant amount of concurrent
traffic such that many logs from different state machines are being
emitted at the same time. This patch updates logging calls to more
consistently add the associated state machine ID for such logs.