Skip to content

Fixes issue #8807 nexthop failure threshold in ATS 9.1.x #8812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrushford wants to merge 1 commit into from
Closed

Fixes issue #8807 nexthop failure threshold in ATS 9.1.x #8812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions proxy/http/remap/NextHopHealthStatus.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,22 +119,21 @@ NextHopHealthStatus::markNextHop(TSHttpTxn txn, const char *hostname, const int
new_fail_count = h->failCount = 1;
}
} else if (result.retry == true) {
h->failedAt = _now;
h->failedAt = _now;
new_fail_count = h->failCount = 1;
}
} // end lock guard
NH_Note("[%" PRId64 "] NextHop %s marked as down %s", sm_id, (result.retry) ? "retry" : "initially", h->hostname.c_str());
} else {
int old_count = 0;
// if the last failure was outside the retry window, set the failcount to 1 and failedAt to now.
{ // lock guard
std::lock_guard<std::mutex> lock(h->_mutex);
if ((h->failedAt + retry_time) < static_cast<unsigned>(_now)) {
h->failCount = 1;
h->failedAt = _now;
new_fail_count = h->failCount = 1;
h->failedAt = _now;
} else {
old_count = h->failCount = 1;
new_fail_count = h->failCount += 1;
}
new_fail_count = old_count + 1;
} // end of lock_guard
NH_Debug(NH_DEBUG_TAG, "[%" PRId64 "] Parent fail count increased to %d for %s", sm_id, new_fail_count, h->hostname.c_str());
}
Expand Down