9.1.x: Unit test compiler and library run time fixes #8814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a signed type warning and a library runtime warning in the unit (Catch) tests.
bneradt
requested review from
SolidWallOfCode,
bryancall and
zwoop
as code owners
bneradt
changed the title
Contributor
Author
|
The CI here will require the Catch tests to be updated in 9.1.x before they will pass: |
Contributor
Author
|
Oh, the autests on 9.1.x are failing because we need this as well in 9.1.x to fix httpbin: |
randall
approved these changes
May 1, 2022
Contributor
|
[approve ci autest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a signed type warning and a library runtime warning in the unit
(Catch) tests.