Skip to content

Conversation

@ywkaras
Copy link
Contributor

@ywkaras ywkaras commented May 6, 2022

No description provided.

@ywkaras ywkaras requested review from bryancall and zwoop as code owners May 6, 2022 15:50
@ywkaras ywkaras self-assigned this May 6, 2022
@ywkaras ywkaras added Cleanup Debug Support for system debugging labels May 6, 2022
@ywkaras ywkaras added this to the 10.0.0 milestone May 6, 2022
@ywkaras
Copy link
Contributor Author

ywkaras commented May 6, 2022

This change is to prepare for #8830 , which requires debug tags in HttpSM to be valid suffixes of C/C++ identifiers.

@maskit
Copy link
Member

maskit commented May 8, 2022

I'm fine with making this change on 10.0, but have a little concern on backporting it to 9.x. Although it's just a debug tag name change, I think it's technically an incompatible change. I personally don't mind, but thought it's better to make a consensus.

I found several other tag names that don't follow the new rule. I guess those have to be changed as well when we use the new debug interface. If we are going to change ip-allow we should probably change the others as well.

Here's the incomplete list:

  • log-file
  • log-filter-compare
  • log-agg
  • log-logbuffer
  • log-config
  • log-config-transfer
  • log-api-mutex
  • Trie::Insert

@ywkaras
Copy link
Contributor Author

ywkaras commented May 9, 2022

We would have to backport this if we want to backport #8830 . The question we must consider is if there will be further changes to HttpSM.cc that will be backported to 9.x . I'm worried about difficult merge conflicts, if we must backport changes to HttpSM.cc that follow #8830 , if #8830 is not backported.

@bryancall bryancall requested a review from SolidWallOfCode May 9, 2022 23:04
@ywkaras ywkaras merged commit 14b7c3b into apache:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Debug Support for system debugging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants