Skip to content

Conversation

@brbzull0
Copy link
Contributor

It was wrongly calling admin_server_start_drain when it was supposed to call admin_server_stop_drain.

$ traffic_ctl server drain --undo -f rpc
--> {"id": "af5e7d34-8143-45be-98d0-448ad2c3cb01", "jsonrpc": "2.0", "method": "admin_server_stop_drain"}
<-- {"jsonrpc": "2.0", "result": "success", "id": "af5e7d34-8143-45be-98d0-448ad2c3cb01"}

…alling admin_server_start_drain when it was supposed to call admin_server_stop_drain.
@brbzull0 brbzull0 added the JSONRPC JSONRPC 2.0 related work. label May 19, 2022
@brbzull0 brbzull0 added this to the 10.0.0 milestone May 19, 2022
@brbzull0 brbzull0 requested a review from bryancall as a code owner May 19, 2022 14:22
@brbzull0 brbzull0 self-assigned this May 19, 2022
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward.

I'll let a non-Yahoo! approve it.

@bryancall bryancall requested review from SolidWallOfCode and removed request for SolidWallOfCode May 23, 2022 23:04
@bryancall
Copy link
Contributor

@serrislew will review this

@serrislew
Copy link
Contributor

Looks good to me.

@brbzull0 brbzull0 merged commit d68719d into apache:10-Dev May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JSONRPC JSONRPC 2.0 related work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants