Skip to content

Deprecate TSSslSecretGet (not thread safe). #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ywkaras wants to merge 1 commit into from
Closed

Deprecate TSSslSecretGet (not thread safe). #8862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/developer-guide/api/functions/TSSslSecret.en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ from the :cpp:enumerator:`TS_LIFECYCLE_SSL_SECRET_HOOK`.
TSSslSecretGet
**************

Get the data associated with a secret name specified in the config.
Get the data associated with a secret name specified in the config. **Note:** this function is deprecated, it is not
thread safe. It will be replaced with a thread-safe function in Release 10.

Synopsis
========
Expand Down
2 changes: 2 additions & 0 deletions include/ts/ts.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,6 +1304,8 @@ tsapi TSReturnCode TSSslServerCertUpdate(const char *cert_path, const char *key_

/* Update the transient secret table for SSL_CTX loading */
tsapi TSReturnCode TSSslSecretSet(const char *secret_name, int secret_name_length, const char *secret_data, int secret_data_len);
/* NOTE: TSSslSecretGet() is deprecated, it is not thread-safe. It will be replaced with a thread-safe function
** in Release 10 */
Copy link
Contributor

@brbzull0 brbzull0 Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use TS_DEPRECATED ?

Copy link
Contributor Author

@ywkaras ywkaras Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS_MAYBE

tsapi TSReturnCode TSSslSecretGet(const char *secret_name, int secret_name_length, const char **secret_data_return,
int *secret_data_len);

Expand Down