Skip to content

Conversation

@ywkaras
Copy link
Contributor

@ywkaras ywkaras commented Jun 2, 2022

No description provided.

@ywkaras ywkaras self-assigned this Jun 2, 2022
@ywkaras ywkaras force-pushed the rm_ats_scoped_obj branch from 744e249 to 00c5361 Compare June 2, 2022 22:01
@rob05c
Copy link
Member

rob05c commented Jun 2, 2022

+1 on moving to std

It looks like it's only used in a few places, though. Could we just delete ats_scoped_obj entirely and change all the usages to std::unique_ptr?

@maskit
Copy link
Member

maskit commented Jun 3, 2022

Could we just delete ats_scoped_obj entirely and change all the usages to std::unique_ptr?

+1

@ywkaras ywkaras force-pushed the rm_ats_scoped_obj branch from 00c5361 to f05553c Compare June 3, 2022 20:29
@randall randall modified the milestone: 10.0.0 Jun 6, 2022
@ywkaras ywkaras merged commit b91b573 into apache:master Jun 6, 2022
zwoop pushed a commit that referenced this pull request Jun 7, 2022
Co-authored-by: Walt Karas <wkaras@yahooinc.com>
(cherry picked from commit b91b573)
@zwoop
Copy link
Contributor

zwoop commented Jun 7, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Jun 7, 2022
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Updated ChangeLog
  Add proxy.process.hostdb.total_serve_stale (apache#8873)
  Allow for long Http* error.log lines (apache#8855)
  mkdfa.c is not being used and doesn't compile with gcc 12.1.1 (apache#8838)
  Add compatibility define when building with OpenSSL3 (apache#8837)
  Make post-early-return Au test more robust. (apache#8832)
  Add support for caching complete responses to the cache range requests plugin (apache#8816)
  Fixes issues with the CRR plugin introduced in apache#8488 (apache#8828)
  slice and cache_range_requests: allow header override (apache#8666) (apache#8898)
  Removed references to the throttle option from the slice plugin. (apache#8373) (apache#8897)
  cache_range_requests plugin: don't require 206 Partial Content reason string (apache#8488)
  Improve option processing in cache promote (apache#8501)
  Change parent_select Init func to constructor (apache#8853)
  Fix "is is" typos. (apache#8866)
  Eliminate duplicate words. (apache#8870)
  money_trace: allow custom header, change span-id gen, opt to create if none (apache#8655)
  Update HostDBContinuation timeout handling to clear pending queue. (apache#8480)
  Upgrade to Proxy Verifier 2.4.0. (apache#8884)
  Change ats_scoped_obj to std::unique_ptr . (apache#8882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants