AuTest: bind stdout/stderr to traffic.out #8919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates our AuTest invocation of traffic_server to bind its stdout and stderr output to traffic.out. Doing this allows the tests to dynamically interact with the traffic.out content, such as waiting upon certian debug tag lines. It also serves as a debugging convenience since all logging output for a Traffic Server process will be in its log dir: diags.log, error.log, etc., and now traffic.out.
bneradt
force-pushed
the
autest_stdout_traffic_out
branch
from
012f188 to
b0c092c
Compare
bneradt
commented
Jun 18, 2022
Comment on lines
-31
to
-34
| # It is necessary to redirect stderr to a file so it will be available for examination by a test run. | ||
| ts = Test.MakeATSProcess( | ||
| "ts", command="traffic_manager 2> " + Test.RunDirectory + "/ts.stderr.txt", select_ports=True | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is an example of something no longer necessary with this patch since we bind stdout and stderr to traffic.out. Instead we can simply interact with traffic.out.
randall
approved these changes
Jun 20, 2022
|
I'm not sure if it's an issue. I noticed that in file: Lines 225 to 229 begin with ts1.Disk.traffic_out.Content but maybe should begin with: |
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Jun 22, 2022
This fixes the stek_share.test.py AuTest to verify the traffic.out output against the correct ts process, rather than just using ts1 for each check. This is fixing a copy and paste bug introduced in apache#8919.
Contributor
Author
Good catch, @marcin-wadolkowski . Fixing in #8921. |
bneradt
added a commit
that referenced
this pull request
Jun 22, 2022
This fixes the stek_share.test.py AuTest to verify the traffic.out output against the correct ts process, rather than just using ts1 for each check. This is fixing a copy and paste bug introduced in #8919.
Contributor
|
We need this for other PRs to CP. Cherry-picked to v9.2.x |
zwoop
pushed a commit
that referenced
this pull request
Nov 17, 2022
This updates our AuTest invocation of traffic_server to bind its stdout and stderr output to traffic.out. Doing this allows the tests to dynamically interact with the traffic.out content, such as waiting upon certian debug tag lines. It also serves as a debugging convenience since all logging output for a Traffic Server process will be in its log dir: diags.log, error.log, etc., and now traffic.out. (cherry picked from commit 3a4c3db)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
This updates our AuTest invocation of traffic_server to bind its stdout and stderr output to traffic.out. Doing this allows the tests to dynamically interact with the traffic.out content, such as waiting upon certian debug tag lines. It also serves as a debugging convenience since all logging output for a Traffic Server process will be in its log dir: diags.log, error.log, etc., and now traffic.out. (cherry picked from commit 3a4c3db)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Revert "Make separate read and write vc_handlers (apache#8301)" AuTest: Update to Proxy Verifier 2.5.2 (apache#9223) AuTest: Update to Proxy Verifier v2.5.0 (apache#9221) Updated ChangeLog Adding back set_connect_fail for generic I/O error (apache#9181) AuTest: make MakeATSProcess accessible for TestRuns (apache#9195) Traffic Dump: Allow unlimited disk utilization (apache#9186) AuTest: bind stdout/stderr to traffic.out (apache#8919) Adds support for serving statichit content out of a directory (apache#9107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our AuTest invocation of traffic_server to bind its stdout
and stderr output to traffic.out. Doing this allows the tests to
dynamically interact with the traffic.out content, such as waiting upon
certian debug tag lines. It also serves as a debugging convenience since
all logging output for a Traffic Server process will be in its log dir:
diags.log, error.log, etc., and now traffic.out.