Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the autopep8 clang-format targets quieter #8944

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

bneradt
Copy link
Contributor

@bneradt bneradt commented Jul 7, 2022

This makes our clang-format and autopep8 execution quieter. They will
now only print any files that they modified.


While working on #8935 I realized that we all would have seen the issue of these files being modified had our clang-format output been quieter. This addresses that by only printing the files modified by clang-format and autopep8. I've tested this both on MacOS and Linux.

Here's example output with three files being formatted by the clang-format and autopep8 targets:

$ make -j8 format
/Library/Developer/CommandLineTools/usr/bin/make clang-format-src clang-format-example clang-format-iocore clang-format-lib clang-format-mgmt clang-format-plugins clang-format-proxy clang-format-tools
./tests/gold_tests/proxy_protocol/proxy_serve_stale.test.py
./plugins/experimental/metalink/test/http09
./proxy/hdrs/URL.cc

@bneradt bneradt added the Build work related to build configuration or environment label Jul 7, 2022
@bneradt bneradt added this to the 10.0.0 milestone Jul 7, 2022
@bneradt bneradt requested a review from randall July 7, 2022 17:37
@bneradt bneradt self-assigned this Jul 7, 2022
tools/clang-format.sh Outdated Show resolved Hide resolved
This makes our clang-format and autopep8 execution quieter. They will
now only print any files that they modified.
@bneradt bneradt force-pushed the quieter_clang_format_output branch from c1cdcc7 to 1467e54 Compare July 7, 2022 19:21
@bneradt bneradt merged commit f3173bb into apache:master Jul 8, 2022
@bneradt bneradt deleted the quieter_clang_format_output branch July 8, 2022 16:23
@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Jul 13, 2022
zwoop pushed a commit that referenced this pull request Jul 13, 2022
This makes our clang-format and autopep8 execution quieter. They will
now only print any files that they modified.

(cherry picked from commit f3173bb)
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
This makes our clang-format and autopep8 execution quieter. They will
now only print any files that they modified.

(cherry picked from commit f3173bb)
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x: (22 commits)
  Updated ChangeLog
  Add 5xx's to be allowed to be used for simple retries (apache#8518)
  Extend milestone api time tracking to remap. (apache#8520)
  Destroy ssl context after use. (apache#8531)
  Proxy Verifier: Update to version 2.4.1 (apache#8965)
  Fixes issue with file size calculation for existing logs (apache#8971)
  Fix reverting PR#7302 (apache#8975)
  add a metric to track how often the range seek bug is detected (apache#8970)
  Updated ChangeLog
  Revert "File change monitoring on s3_auth (apache#8905)"
  .fit/fmt/.clang-format-installed prerequisite (apache#8950)
  Make the autopep8 clang-format targets quieter (apache#8944)
  Add option to disable JIT in lua plugin (apache#8618)
  Fix doc formatting for plugin remap_stats (apache#8942)
  Fix doc formatting for rate_limit plugin (apache#8943)
  Clear lua plugin http context after each hook handler (apache#8607)
  LGTM: Remove function declaration in block (HdrHeap.cc) (apache#8588)
  ESI processing when origin returns 304 response (apache#8563)
  call je_dallocx with flags when needed (apache#8547)
  Updated ChangeLog
  ...

 Conflicts:
	CHANGELOG-9.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build work related to build configuration or environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants