Skip to content

make doc corrupt for content length mismatch #8968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmamidi wants to merge 1 commit into from
Closed

make doc corrupt for content length mismatch #8968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion iocore/cache/CacheRead.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,13 +721,20 @@ CacheVC::openReadMain(int /* event ATS_UNUSED */, Event * /* e ATS_UNUSED */)
key.toHexStr(target_key_str));
}

bool doc_corrupt = false;
CacheHTTPInfo *ainfo = nullptr;
get_http_info(&ainfo);
MIMEField *field = ainfo->m_alt->m_response_hdr.field_find(MIME_FIELD_CONTENT_LENGTH, MIME_LEN_CONTENT_LENGTH);
if (field && field->value_get_int64() != doc->len)
doc_corrupt = true;

// This shouldn't happen for HTTP assets but it does
// occasionally in production. This is a temporary fix
// to clean up broken objects until the root cause can
// be found. It must be the case that either the fragment
// offsets are incorrect or a fragment table isn't being
// created when it should be.
if (frag_type == CACHE_FRAG_TYPE_HTTP && bytes < 0) {
if (frag_type == CACHE_FRAG_TYPE_HTTP && (bytes < 0 || doc_corrupt)) {
char xt[CRYPTO_HEX_SIZE];
char yt[CRYPTO_HEX_SIZE];

Expand Down