Skip to content

Conversation

@rob05c
Copy link
Member

@rob05c rob05c commented Aug 10, 2022

Documents an undocumented field. Because I got tired of looking it up in the code.

This applies to both core and parent_select plugin strategies.

Should be backported to 9.2, 9.1, and 9.0. The config has existed since 9.0, and there's no reason not to document it there.

Also clarified that host is the FQDN. Prior docs could have been interpreted as the short hostname.

@rob05c rob05c added this to the 10.0.0 milestone Aug 10, 2022
@rob05c rob05c self-assigned this Aug 10, 2022
health_check_url: https://192.168.1.1:443
- &p2
host: p2.foo.com
host: p2.new.foo.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes foo tastes fresher when it's new.

ywkaras
ywkaras previously approved these changes Aug 11, 2022
@ywkaras ywkaras dismissed their stale review August 11, 2022 14:06

Didn't notice the Docs PR check was failing.

@traeak
Copy link
Contributor

traeak commented Aug 12, 2022

[approve ci]

1 similar comment
@ezelkow1
Copy link
Member

[approve ci]

@rob05c
Copy link
Member Author

rob05c commented Aug 15, 2022

[approve ci docs]

@rob05c rob05c force-pushed the add-strategy-hash-docs branch from 2bff8f6 to 5633d3c Compare August 15, 2022 23:07
@rob05c rob05c requested a review from ywkaras August 16, 2022 22:25
@bryancall
Copy link
Contributor

[approve ci autest]

@rob05c rob05c merged commit 8836072 into apache:master Oct 20, 2022
zwoop pushed a commit that referenced this pull request Nov 1, 2022
@zwoop
Copy link
Contributor

zwoop commented Nov 1, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Nov 1, 2022
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Nov 15, 2022
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Updated ChangeLog
  Add docs for strategies.yaml hash_string (apache#9026)
  Fix hosting.config reloading (apache#9046)
  Remove unnecessary, dangerous casts from SET_HANDLER and SET_CONTINUATION invocations. (apache#9129)
  Remove deprecated ld option (--add-needed) (apache#9141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants