Adds efficient IP range matching to HRW conditions #9031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is only lightly tested for now. I'm mostly sticking to the existing code patterns in header_rewrite, so no bike shedding without looking what the existing code already does. :). |
Member
|
[approve ci] |
2 similar comments
Member
|
[approve ci] |
Contributor
|
[approve ci] |
Contributor
|
[approve ci autest] |
Contributor
Author
|
[approve ci autest] |
1 similar comment
Member
|
[approve ci autest] |
SolidWallOfCode
approved these changes
Aug 31, 2022
Contributor
Author
|
[approve ci autest] |
zwoop
added a commit
that referenced
this pull request
Aug 31, 2022
* Adds efficient IP range matching to HRW conditions * Changes to use the native TextView parser * Fixes typo in docs * Undo the hack around macos builds failing * Adds failure checks from IP range parsing (cherry picked from commit c58edbb)
Contributor
Author
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Adds efficient IP range matching to HRW conditions (apache#9031) Test: add nameserver to proxy_serve_stale test (apache#9059) (apache#9070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow for much more efficient IP address checks, rather than having to convert IPs to strings (multiple times) and do string comparisons.
Jeff E. suggested we ought to generalize the notion of "ranges" in matching here, but I'd like to leave that for a future addition.