Skip to content

Fix compile error on macOS #9047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bneradt merged 1 commit into from
Aug 19, 2022
Merged

Fix compile error on macOS #9047

bneradt merged 1 commit into from
Aug 19, 2022

Conversation

@maskit
Copy link
Member

@maskit maskit commented Aug 19, 2022 •
edited
Loading 

CacheRead.cc:1185:19: error: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
                  cl, doc_len);
                  ^~
../../include/tscore/Diags.h:87:45: note: expanded from macro 'Warning'
#define Warning(...) DiagsError(DL_Warning, __VA_ARGS__)     // Log concerning information
                                            ^~~~~~~~~~~
../../include/tscore/Diags.h:82:59: note: expanded from macro 'DiagsError'
    DiagsError_log_message.message(LEVEL, DiagsError_loc, __VA_ARGS__); \
                                                          ^~~~~~~~~~~
CacheRead.cc:1185:23: error: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
                  cl, doc_len);
                      ^~~~~~~
../../include/tscore/Diags.h:87:45: note: expanded from macro 'Warning'
#define Warning(...) DiagsError(DL_Warning, __VA_ARGS__)     // Log concerning information
                                            ^~~~~~~~~~~
../../include/tscore/Diags.h:82:59: note: expanded from macro 'DiagsError'
    DiagsError_log_message.message(LEVEL, DiagsError_loc, __VA_ARGS__); \
                                                          ^~~~~~~~~~~

@maskit maskit added the Build work related to build configuration or environment label Aug 19, 2022
@maskit maskit added this to the 10.0.0 milestone Aug 19, 2022
@maskit maskit self-assigned this Aug 19, 2022
@maskit
Copy link
Member Author

maskit commented Aug 19, 2022 •
edited
Loading

If #8976 goes to 9.2.x, we need this as well.

@bneradt bneradt merged commit 1131985 into apache:master Aug 19, 2022
zwoop pushed a commit that referenced this pull request Aug 23, 2022
@maskit @zwoop
Fix compile error on macOS (#9047)
32125d3 
(cherry picked from commit 1131985)
@zwoop
Copy link
Contributor

zwoop commented Aug 23, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Aug 23, 2022
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Aug 23, 2022
@maskit @cmcfarlen
Fix compile error on macOS (apache#9047)
81f8ad9
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
@zwoop
Merge remote-tracking branch 'asf/9.2.x' into 9.2.x
1ffe826 
* asf/9.2.x:
  Updated ChangeLog
  utilize proxy.config.hostdb.host_file.interval config variable (apache#9039)
  Remove plugin parent_select unused symbols (apache#9023)
  Require use of 'override' keyword when valid. (apache#8737)
  Fix compile error on macOS (apache#9047)
  Validate that content length header matches object size on cache read (apache#8976)
  Fix reload memory leak (apache#9041)
  Update prepare_proxy_verifier.sh to work in non-git directories (apache#9048)
  Change linux/fs include to build with glibc 2.36 (apache#9027)
  ts::shared_mutex - Fix lock counting for debug (apache#9040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bneradt bneradt bneradt approved these changes

Assignees

@maskit maskit

Labels

Build work related to build configuration or environment

Projects

None yet

Milestone

9.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@maskit @zwoop @bneradt