Fix the connection limit crash while using parents (#7602) #9052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e8db7c4)
Member
Author
|
Also we are currently putting out builds to prod with this picked in (9.2 based builds) so we can hold off until we get some test time in production if we want more concrete evidence. The push behind this for us was our original 9.2 production boxes were getting sporadic crashes exactly like those reported in the original issue which led me down this path |
vmamidi
approved these changes
Aug 24, 2022
zwoop
pushed a commit
that referenced
this pull request
Aug 25, 2022
Contributor
|
Cherry-picked to v9.2.x |
Closed
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Fix the connection limit crash while using parents (apache#7602) (apache#9052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e8db7c4)
The original fix for this on master was in #7604 however I think a lot of that code got reverted on master during prep for 9.2. In the mean time a fix went into 9.0/9.1 in #7602 . That fix was then never brought into master with the reverted code or on 9.2. So we need this both in master and picked back to 9.2