Add Au test for TSVConnFdCreate(). #9063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
force-pushed
the
TSVConnFd
branch
2 times, most recently
from
86c6226 to
55dbe18
Compare
Contributor
Author
|
The review could be split between two reviewers. One could review TSVConnFd.cc lines 1 - 429. The other could review the rest of that file and the other files. |
moonchen
requested changes
Dec 23, 2022
| # | ||
| tr = Test.AddTestRun() | ||
| tr.Processes.Default.Command = ( | ||
| "N=10 ; while ((N > 0 )) ; do " + |
Contributor
There was a problem hiding this comment.
This script doesn't work on dash (default for /bin/sh on Ubuntu). Suggested change:
"N=10 ; while [ $$N -gt 0 ] ; do " +
"if [ ! -f " + InProgressFilePathspec + " ] ; then exit 0 ; fi ; sleep 1 ; N=$$(( N-1 )) ; " +
"done ; echo 'TIMEOUT' ; exit 1"
moonchen
approved these changes
Dec 23, 2022
ywkaras
added a commit
to ywkaras/trafficserver
that referenced
this pull request
Dec 23, 2022
* Add Au test for TSVConnFdCreate(). * Make TSVConnFd Au test dash shell compatible. Co-authored-by: Walt Karas <wkaras@yahooinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.