Skip to content

TSan: Fix data race of updating current time #9168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masaori335 wants to merge 1 commit into from
Closed

TSan: Fix data race of updating current time #9168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion iocore/eventsystem/I_Thread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
#include "tscore/ink_thread.h"
#include "I_ProxyAllocator.h"

#include <atomic>

class ProxyMutex;

constexpr int MAX_THREAD_NAME_LENGTH = 16;
Expand Down Expand Up @@ -177,7 +179,7 @@ class Thread
protected:
Thread();

static ink_hrtime cur_time;
static std::atomic<ink_hrtime> cur_time;
Copy link
Contributor Author

@masaori335 masaori335 Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread::cur_time is shared across threads.

trafficserver/iocore/eventsystem/I_Thread.h

Lines 159 to 160 in a5f647a

@note The cached copy shared among threads which means the cached copy is updated
for all threads if any thread updates it.

};

extern Thread *this_thread();
Expand Down
2 changes: 1 addition & 1 deletion iocore/eventsystem/Thread.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
// Common Interface impl //
///////////////////////////////////////////////

ink_hrtime Thread::cur_time = ink_get_hrtime_internal();
std::atomic<ink_hrtime> Thread::cur_time = ink_get_hrtime_internal();
thread_local Thread *Thread::this_thread_ptr;

Thread::Thread()
Expand Down