Skip to content

Conversation

@SolidWallOfCode
Copy link
Member

@SolidWallOfCode SolidWallOfCode commented Nov 15, 2022

A precursor to #9193 to split out some of the changes.

This enables using Errata with the internal ATS severity levels. One of the changes to Errata from ATS core to libswoc was to enable this convergence of values.

The levels are put into the CPP util directory to avoid circular dependencies in building, e.g. nothing in that directory depends on things built later.

Due to various linking problems, this requires #9203

@SolidWallOfCode SolidWallOfCode added this to the 10-Dev milestone Nov 15, 2022
@SolidWallOfCode SolidWallOfCode self-assigned this Nov 15, 2022
@SolidWallOfCode SolidWallOfCode force-pushed the errata-severity branch 3 times, most recently from 7f2416b to a1d5892 Compare November 16, 2022 00:47
Copy link
Contributor

@brbzull0 brbzull0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I needed this!

@SolidWallOfCode SolidWallOfCode force-pushed the errata-severity branch 4 times, most recently from 7fa4315 to f150e3d Compare November 17, 2022 17:19
@SolidWallOfCode SolidWallOfCode force-pushed the errata-severity branch 2 times, most recently from d18f051 to eada557 Compare November 18, 2022 16:14
@bneradt
Copy link
Contributor

bneradt commented Nov 18, 2022

The OSX error link:
https://ci.trafficserver.apache.org/job/Github_Builds/job/osx/406/console

Undefined symbols for architecture x86_64:
  "swoc::_1_4_0::Errata::SEVERITY_NAMES", referenced from:
      __GLOBAL__sub_I_ts_diags.cc in ts_diags.o
  "swoc::_1_4_0::Errata::DEFAULT_SEVERITY", referenced from:
      __GLOBAL__sub_I_ts_diags.cc in ts_diags.o
  "swoc::_1_4_0::Errata::FAILURE_SEVERITY", referenced from:
      __GLOBAL__sub_I_ts_diags.cc in ts_diags.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [libtscpputil.la] Error 1
make: *** [all-recursive] Error 1

@SolidWallOfCode SolidWallOfCode merged commit 9c6eb61 into apache:10-Dev Nov 18, 2022
@zwoop zwoop modified the milestones: 10-Dev, 10.0.0 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants