libswoc: Add ATS IP address utitilies on top of libswoc. #9209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
force-pushed
the
ts_ip
branch
from
2350d00 to
ca353fc
Compare
SolidWallOfCode
force-pushed
the
ts_ip
branch
from
ca353fc to
53199cc
Compare
SolidWallOfCode
force-pushed
the
ts_ip
branch
from
14977f3 to
bb0a6ff
Compare
bneradt
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was showing up in multiple other PRs therefore I think it best to break it out as a distinct PR. See #9208 , #9207, #9193.
This is the eventual replacement for "ink_inet.h" and "ink_inet.cc". Presumably all of the facilities there are now in libswoc. In real life I expect to find missing bits so this will be done incrementally with this as the starting point.
Additional utilities are being added based on need as other conversions to libswoc are done. In particular the address and service pairs are a pattern that shows up commonly but current is done with hand rolled code. See
getbestaddrinfofor an example of this.The differences between this PR and the same files in other PRs is I have done comment cleanup to make sure there's full Doxygen commenting on the new code.