RefCountObj - further improvements wrt copy construction. #9235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR overlaps with #9217 . |
cmcfarlen
requested changes
Dec 13, 2022
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
This doesn't compile on CI because plugins/experimental/memcache/tsmemcache.cc needs to include tscore/ink_atomic.h.
SolidWallOfCode
force-pushed
the
refcountobj-even-better
branch
2 times, most recently
from
f37d803 to
eb70e54
Compare
SolidWallOfCode
force-pushed
the
refcountobj-even-better
branch
from
eb70e54 to
40480f8
Compare
ywkaras
approved these changes
Dec 20, 2022
cmcfarlen
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this was already partially done, but this PR removes the
RefCountObjcopy constructor and fixes the resulting compile problems. It also changes that class to use standard atomics instead of ATS functions.