Add slice config to strip Range header for HEAD requests #9238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traeak
previously approved these changes
Dec 12, 2022
Contributor
traeak
left a comment
traeak
left a comment
There was a problem hiding this comment.
Tests run fine, looks okay.
bryancall
requested changes
Dec 13, 2022
Contributor
Author
|
[approve ci autest] |
bneradt
requested changes
Jan 2, 2023
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good to me. I just have a few minor test suggestions.
tests/gold_tests/pluginTest/slice/replay/slice_range.replay.yaml
Outdated
Show resolved
Hide resolved
bryancall
approved these changes
Jan 12, 2023
Contributor
|
I'm going to defer this to 10.0.0, since it's a feature change and I really don't want to make a 9.3.0 release but rather focus on 10.0.0. |
Member
|
id be +1 on this for 9.2.1, it's an experimental plugin so not a large change to core code and its pretty isolated in the change as well |
zwoop
pushed a commit
that referenced
this pull request
Jan 25, 2023
* Add slice plugin config to strip Range header for HEAD requests * Remove trailing whitespaces * Add Head to config name for clarity * Add verification directives to autest replay Co-authored-by: Serris Lew <lserris@apple.com> (cherry picked from commit b5c45a3)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Add slice config to strip Range header for HEAD requests (apache#9238) s3_auth: Schedule reloading config event on TASK thread (apache#9328) Don't send response body on status 204 No Content (apache#9330)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config in slice plugin to remove Range header from HEAD requests. When enabled, HEAD requests going through slice will always return full object content length
@pparam=--strip-range-for-head