Remove cqhv log field #9258
Merged
Remove cqhv log field #9258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zizhong
reviewed
Dec 16, 2022
proxy/logging/LogAccess.cc
Outdated
| The http text is simply the fields http_method (cqhm) + url (pqu) + | ||
| http_version (cqhv), all right next to each other, in that order. | ||
| http_version (cqhv, which was removed on 10.0.0), all right next to each other, in that order. |
Member
There was a problem hiding this comment.
should we remove the mentioning of cqhv?
Member
Author
There was a problem hiding this comment.
Yea, I thought about it, but I was too lazy. How about this:
The http text is a reproduced HTTP/1.x request line. It's HTTP method (cqhm) + URL (pqu) + HTTP version. This doesn't support HTTP/2 and HTTP/3 since those don't have a request line.
bneradt
approved these changes
Dec 20, 2022
maskit
added a commit
to maskit/trafficserver
that referenced
this pull request
Aug 15, 2024
This is for apache#9019 and apache#9258.
maskit
added a commit
to maskit/trafficserver
that referenced
this pull request
Aug 15, 2024
This is for apache#9019 and apache#9258.
maskit
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
cqhvlog field. It was deprecated on 9.0.0.https://lists.apache.org/thread/zqmo3sj1m1s6tv9b7zdo86q0qpf2mjow
Unfortunately, we can't remove the marshaling and unmarshaling functions. The marshaling function is also used for
cqtx, which reproduces HTTP/1.x request line. The unmarshaling function is also used for server request.