Fix crashes at shutdown due to references to stale debug control registry. #9272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
force-pushed
the
DbgCtlDestroy
branch
from
3d0fd28 to
6496088
Compare
ywkaras
force-pushed
the
DbgCtlDestroy
branch
7 times, most recently
from
d530972 to
178221c
Compare
…stry. Adds reference count for references to registry. The registry is deleted only when the reference count goes to zero.
The opening of the cleartext TCP port for listening fails intermittently with a delay beforehand.
ywkaras
force-pushed
the
DbgCtlDestroy
branch
from
37e890c to
4024dd1
Compare
cmcfarlen
approved these changes
Dec 29, 2022
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
This PR looks good and it does prevent crashes at shutdown.
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
…stry. (apache#9272) (apache#755) * Move Cleanup.h from plugins/xdebug to incude/tscpp/api . (apache#9080) Co-authored-by: Walt Karas <wkaras@yahooinc.com> (cherry picked from commit 40e8335) * Fix crashes at shutdown due to references to stale debug control registry. (apache#9272) * Fix crashes at shutdown due to references to stale debug control registry. Adds reference count for references to registry. The registry is deleted only when the reference count goes to zero. * Add delay before starting trafficserver in tsapi Au test. The opening of the cleartext TCP port for listening fails intermittently with a delay beforehand. Co-authored-by: Walt Karas <wkaras@yahooinc.com> (cherry picked from commit eabc29e) CONFLICTS: include/tscpp/api/Cleanup.h src/tscore/DbgCtl.cc tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc tests/gold_tests/pluginTest/polite_hook_wait/polite_hook_wait.cc Co-authored-by: Walt Karas <wkaras@yahoo-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds reference count for references to registry. The registry is deleted only when the reference count goes to zero.