Skip to content

Remove deprecated TS API #9273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 3 commits into from
Jan 3, 2023
Merged

Remove deprecated TS API #9273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb35e15
Remove deprecated TS APIs
maskit Dec 22, 2022
5e3f9a9
Update documenet
maskit Dec 22, 2022
969f75b
Fix doc format
maskit Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 0 additions & 102 deletions doc/developer-guide/api/functions/TSHttpArgs.en.rst
View file
Open in desktop

This file was deleted.

88 changes: 0 additions & 88 deletions doc/developer-guide/api/functions/TSVConnArgs.en.rst
View file
Open in desktop

This file was deleted.

18 changes: 18 additions & 0 deletions doc/release-notes/upgrading.en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,24 @@ The following features, configurations and plugins are either removed or depreca
version of ATS. Deprecated features should be avoided, with the expectation that they will be
removed in the next major release of ATS.

* Removed TS API

* TSHttpTxnArgSet
* TSHttpTxnArgGet
* TSHttpSsnArgSet
* TSHttpSsnArgGet
* TSVConnArgSet
* TSVConnArgGet
* TSHttpTxnArgIndexReserve
* TSHttpTxnArgIndexNameLookup
* TSHttpTxnArgIndexLookup
* TSHttpSsnArgIndexReserve
* TSHttpSsnArgIndexNameLookup
* TSHttpSsnArgIndexLookup
* TSVConnArgIndexReserve
* TSVConnArgIndexNameLookup
* TSVConnArgIndexLookup


API Changes
-----------
Expand Down
18 changes: 0 additions & 18 deletions include/ts/ts.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,24 +1638,6 @@ tsapi TSReturnCode TSUserArgIndexLookup(TSUserArgType type, int arg_idx, const c
tsapi void TSUserArgSet(void *data, int arg_idx, void *arg);
tsapi void *TSUserArgGet(void *data, int arg_idx);

/* These are deprecated as of v9.0.0, and will be removed in v10.0.0 */
tsapi TS_DEPRECATED void TSHttpTxnArgSet(TSHttpTxn txnp, int arg_idx, void *arg);
tsapi TS_DEPRECATED void *TSHttpTxnArgGet(TSHttpTxn txnp, int arg_idx);
tsapi TS_DEPRECATED void TSHttpSsnArgSet(TSHttpSsn ssnp, int arg_idx, void *arg);
tsapi TS_DEPRECATED void *TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
tsapi TS_DEPRECATED void TSVConnArgSet(TSVConn connp, int arg_idx, void *arg);
tsapi TS_DEPRECATED void *TSVConnArgGet(TSVConn connp, int arg_idx);

tsapi TS_DEPRECATED TSReturnCode TSHttpTxnArgIndexReserve(const char *name, const char *description, int *arg_idx);
tsapi TS_DEPRECATED TSReturnCode TSHttpTxnArgIndexNameLookup(const char *name, int *arg_idx, const char **description);
tsapi TS_DEPRECATED TSReturnCode TSHttpTxnArgIndexLookup(int arg_idx, const char **name, const char **description);
tsapi TS_DEPRECATED TSReturnCode TSHttpSsnArgIndexReserve(const char *name, const char *description, int *arg_idx);
tsapi TS_DEPRECATED TSReturnCode TSHttpSsnArgIndexNameLookup(const char *name, int *arg_idx, const char **description);
tsapi TS_DEPRECATED TSReturnCode TSHttpSsnArgIndexLookup(int arg_idx, const char **name, const char **description);
tsapi TS_DEPRECATED TSReturnCode TSVConnArgIndexReserve(const char *name, const char *description, int *arg_idx);
tsapi TS_DEPRECATED TSReturnCode TSVConnArgIndexNameLookup(const char *name, int *arg_idx, const char **description);
tsapi TS_DEPRECATED TSReturnCode TSVConnArgIndexLookup(int arg_idx, const char **name, const char **description);

tsapi void TSHttpTxnStatusSet(TSHttpTxn txnp, TSHttpStatus status);
tsapi TSHttpStatus TSHttpTxnStatusGet(TSHttpTxn txnp);

Expand Down
116 changes: 0 additions & 116 deletions src/traffic_server/InkAPI.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6356,122 +6356,6 @@ TSUserArgGet(void *data, int arg_idx)
}
}

// -------------
/* These are deprecated as of v9.0.0, and will be removed in v10.0.0 */
TSReturnCode
TSHttpTxnArgIndexReserve(const char *name, const char *description, int *arg_idx)
{
return TSUserArgIndexReserve(TS_USER_ARGS_TXN, name, description, arg_idx);
}

TSReturnCode
TSHttpTxnArgIndexLookup(int arg_idx, const char **name, const char **description)
{
return TSUserArgIndexLookup(TS_USER_ARGS_TXN, arg_idx, name, description);
}

TSReturnCode
TSHttpTxnArgIndexNameLookup(const char *name, int *arg_idx, const char **description)
{
return TSUserArgIndexNameLookup(TS_USER_ARGS_TXN, name, arg_idx, description);
}

TSReturnCode
TSHttpSsnArgIndexReserve(const char *name, const char *description, int *arg_idx)
{
return TSUserArgIndexReserve(TS_USER_ARGS_SSN, name, description, arg_idx);
}

TSReturnCode
TSHttpSsnArgIndexLookup(int arg_idx, const char **name, const char **description)
{
return TSUserArgIndexLookup(TS_USER_ARGS_SSN, arg_idx, name, description);
}

TSReturnCode
TSHttpSsnArgIndexNameLookup(const char *name, int *arg_idx, const char **description)
{
return TSUserArgIndexNameLookup(TS_USER_ARGS_SSN, name, arg_idx, description);
}

TSReturnCode
TSVConnArgIndexReserve(const char *name, const char *description, int *arg_idx)
{
return TSUserArgIndexReserve(TS_USER_ARGS_VCONN, name, description, arg_idx);
}

TSReturnCode
TSVConnArgIndexLookup(int arg_idx, const char **name, const char **description)
{
return TSUserArgIndexLookup(TS_USER_ARGS_VCONN, arg_idx, name, description);
}

TSReturnCode
TSVConnArgIndexNameLookup(const char *name, int *arg_idx, const char **description)
{
return TSUserArgIndexNameLookup(TS_USER_ARGS_VCONN, name, arg_idx, description);
}

void
TSHttpTxnArgSet(TSHttpTxn txnp, int arg_idx, void *arg)
{
sdk_assert(sdk_sanity_check_txn(txnp) == TS_SUCCESS);

HttpSM *sm = reinterpret_cast<HttpSM *>(txnp);

sm->set_user_arg(arg_idx, arg);
}

void *
TSHttpTxnArgGet(TSHttpTxn txnp, int arg_idx)
{
sdk_assert(sdk_sanity_check_txn(txnp) == TS_SUCCESS);

HttpSM *sm = reinterpret_cast<HttpSM *>(txnp);
return sm->get_user_arg(arg_idx);
}

void
TSHttpSsnArgSet(TSHttpSsn ssnp, int arg_idx, void *arg)
{
sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);

ProxySession *cs = reinterpret_cast<ProxySession *>(ssnp);

cs->set_user_arg(arg_idx, arg);
}

void *
TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
{
sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);

ProxySession *cs = reinterpret_cast<ProxySession *>(ssnp);
return cs->get_user_arg(arg_idx);
}

void
TSVConnArgSet(TSVConn connp, int arg_idx, void *arg)
{
sdk_assert(sdk_sanity_check_iocore_structure(connp) == TS_SUCCESS);
PluginUserArgsMixin *user_args = dynamic_cast<PluginUserArgsMixin *>(reinterpret_cast<VConnection *>(connp));
sdk_assert(user_args);

user_args->set_user_arg(arg_idx, arg);
}

void *
TSVConnArgGet(TSVConn connp, int arg_idx)
{
sdk_assert(sdk_sanity_check_iocore_structure(connp) == TS_SUCCESS);
PluginUserArgsMixin *user_args = dynamic_cast<PluginUserArgsMixin *>(reinterpret_cast<VConnection *>(connp));
sdk_assert(user_args);

return user_args->get_user_arg(arg_idx);
}

/* End deprecated Arg functions. */

void
TSHttpTxnStatusSet(TSHttpTxn txnp, TSHttpStatus status)
{
Expand Down
Loading