Skip to content

Fix autest flakiness #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 3 commits into from
Feb 2, 2023
Merged

Fix autest flakiness #9372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
371e9ca
fatal.test.py autest: make it more reliable
bneradt Feb 2, 2023
65e72bd
remap_load_empty_failure.test.py autest: make it more reliable
bneradt Feb 2, 2023
561567d
emergency.test.py autest: make it more reliable
bneradt Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/gold_tests/remap/remap_load_empty_failure.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
ts.Disk.remap_config.AddLine(f"") # empty file
ts.Disk.records_config.update({'proxy.config.url_remap.min_rules_required': 1})
ts.ReturnCode = 33 # expect to Emergency fail due to empty "remap.config".
ts.Ready = When.FileContains(ts.Disk.diags_log.Name, "remap.config failed to load")

tr = Test.AddTestRun("test")
tr.Processes.Default.Command = "echo"
tr.Processes.Default.StartAfter(ts, ready=When.FileExists(ts.Disk.diags_log))
tr.Processes.Default.Command = "echo howdy"
tr.TimeOut = 5
tr.Processes.Default.StartBefore(ts)
4 changes: 3 additions & 1 deletion tests/gold_tests/shutdown/emergency.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@
tr.Processes.Default.Command = 'printf "Emergency Shutdown Test"'
tr.Processes.Default.ReturnCode = 0
tr.Processes.Default.StartBefore(ts)
tr.Timeout = 5

ts.ReturnCode = 33
ts.Ready = 0 # Need this to be 0 because we are testing shutdown, this is to make autest not think ats went away for a bad reason.
ts.Ready = When.FileContains(ts.Disk.traffic_out.Name, "testing emergency shutdown")
ts.Disk.traffic_out.Content = Testers.ExcludesExpression('failed to shutdown', 'should NOT contain "failed to shutdown"')
ts.Disk.diags_log.Content = Testers.IncludesExpression('testing emergency shutdown', 'should contain "testing emergency shutdown"')
4 changes: 3 additions & 1 deletion tests/gold_tests/shutdown/fatal.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@
tr.Processes.Default.Command = 'printf "Fatal Shutdown Test"'
tr.Processes.Default.ReturnCode = 0
tr.Processes.Default.StartBefore(ts)
tr.Timeout = 5

ts.ReturnCode = 70
ts.Ready = 0 # Need this to be 0 because we are testing shutdown, this is to make autest not think ats went away for a bad reason.
ts.Ready = When.FileContains(ts.Disk.traffic_out.Name, "testing fatal shutdown")
ts.Disk.traffic_out.Content = Testers.ExcludesExpression('failed to shutdown', 'should NOT contain "failed to shutdown"')
ts.Disk.diags_log.Content = Testers.IncludesExpression('testing fatal shutdown', 'should contain "testing fatal shutdown"')