Update h2disable tests for new curl output #9387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The h2disable and h2disable_no_accept_threads autests both had curl output expectations that have changed in the recent release of curl. Here is the old output: ``` Using HTTP2, server supports multiplexing ``` Here is the new output ``` using HTTP/2 ``` This updates the ContainsExpression and ExcludesExpression strings to be able to work with both versions of curl.
randall
approved these changes
Feb 7, 2023
Contributor
Author
|
I'm suggesting we port this back to 9.2.x because it is a test only change that will be annoying if anyone updates their curl and runs autest for the older branch. |
moleksy
pushed a commit
to moleksy/trafficserver
that referenced
this pull request
Feb 8, 2023
The h2disable and h2disable_no_accept_threads autests both had curl output expectations that have changed in the recent release of curl. Here is the old output: ``` Using HTTP2, server supports multiplexing ``` Here is the new output ``` using HTTP/2 ``` This updates the ContainsExpression and ExcludesExpression strings to be able to work with both versions of curl.
zwoop
pushed a commit
that referenced
this pull request
Feb 22, 2023
The h2disable and h2disable_no_accept_threads autests both had curl output expectations that have changed in the recent release of curl. Here is the old output: ``` Using HTTP2, server supports multiplexing ``` Here is the new output ``` using HTTP/2 ``` This updates the ContainsExpression and ExcludesExpression strings to be able to work with both versions of curl. (cherry picked from commit aa33256)
Contributor
|
Cherry-picked to v9.2.x |
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
The h2disable and h2disable_no_accept_threads autests both had curl output expectations that have changed in the recent release of curl. Here is the old output: ``` Using HTTP2, server supports multiplexing ``` Here is the new output ``` using HTTP/2 ``` This updates the ContainsExpression and ExcludesExpression strings to be able to work with both versions of curl. (cherry picked from commit aa33256)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The h2disable and h2disable_no_accept_threads autests both had curl output expectations that have changed in the recent release of curl. Here is the old output:
Here is the new output
This updates the ContainsExpression and ExcludesExpression strings to be able to work with both versions of curl.