9.2.x: http2_flow_control.test.py: Correctly enable debug logs #9508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http2_flow_control.test.py AuTest was ported from 10.x which supports a value of 3 for `proxy.config.diags.debug.enabled`. 9.2.x, however, does not support 3 and therefore debug logging hasn't been working for this test in 9.2.x. This fixes that. This, incidentally, seems to make the test run more reliably in the opensource CI environment.
Contributor
Author
|
Note that this change is a 9.2.x only change. It is not applicable to 10.x since 10.x supports a value of 3 for |
Contributor
Author
|
[approve ci autest] |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
The http2_flow_control.test.py AuTest was ported from 10.x which supports a value of 3 for `proxy.config.diags.debug.enabled`. 9.2.x, however, does not support 3 and therefore debug logging hasn't been working for this test in 9.2.x. This fixes that. This, incidentally, seems to make the test run more reliably in the opensource CI environment. (cherry picked from commit 9cb8564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http2_flow_control.test.py AuTest was ported from 10.x which supports a value of 3 for
proxy.config.diags.debug.enabled. 9.2.x, however, does not support 3 and therefore debug logging hasn't been working for this test in 9.2.x. This fixes that. This, incidentally, seems to make the test run more reliably in the opensource CI environment.